This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Add Query to the cause of exception in QueryObservable#48
Merged
JakeWharton merged 1 commit intoAug 31, 2015
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
I can add a test which will check that query.toString() is part of the stacktrace, but it'll require copy-paste from apache commons or I can add it as test dependency, because retrieving full stacktrace is not so trivial.
JakeWharton
added a commit
that referenced
this pull request
Aug 31, 2015
…ry-to-exception Add Query to the cause of exception in QueryObservable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
Query.toString()will be part of the exception stack trace forQueryObservable.mapToList().Plus 2 little unit tests to assert that
QueryObservablerespects theObservablecontract at least for errors.